Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metric_type for fileds of node datastream #5742

Merged
merged 5 commits into from
Apr 4, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Mar 30, 2023

  • Enhancement

What does this PR do?

This PR adds metric_type for fields of node datastream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ritalwar ritalwar mentioned this pull request Apr 3, 2023
21 tasks
@ritalwar ritalwar marked this pull request as ready for review April 3, 2023 05:31
@ritalwar ritalwar requested a review from a team as a code owner April 3, 2023 05:31
@elasticmachine
Copy link

elasticmachine commented Apr 3, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-04T05:55:21.484+0000

  • Duration: 13 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 3, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 70.0% (14/20) 👍
Lines 73.913% (34/46) 👍
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit 5e3ce4c into elastic:main Apr 4, 2023
@elasticmachine
Copy link

Package rabbitmq - 1.8.6 containing this change is available at https://epr.elastic.co/search?package=rabbitmq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants