Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_umbrella] Revert S3 multiline #5785

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Apr 4, 2023

What does this PR do?

Reverts configuration for handling of multiline messages from Umbrella Auditlogs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@LaZyDK LaZyDK requested a review from a team as a code owner April 4, 2023 12:03
@LaZyDK
Copy link
Contributor Author

LaZyDK commented Apr 4, 2023

This pull is needed to get the Cisco Umbrella integration working again.
After deploying version 1.9.1 we get this error, and data is not being fetched anymore.
Unit state changed aws-s3-default (CONFIGURING->FAILED): [failed to reloading inputs: 1 error: Error creating runner from config: error while parsing multiline parser config: unknown matcher type: accessing 'file_selectors.7.parsers.0.multiline' accessing 'file_selectors.7']

@elasticmachine
Copy link

elasticmachine commented Apr 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-04T16:32:56.692+0000

  • Duration: 15 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 10
Skipped 0
Total 10

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@LaZyDK
Copy link
Contributor Author

LaZyDK commented Apr 4, 2023

Ready to test and merge.

@bhapas
Copy link
Contributor

bhapas commented Apr 4, 2023

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 95.238% (20/21) 👍
Lines 94.805% (511/539) 👍
Conditionals 100.0% (0/0) 💚

@bhapas bhapas merged commit 2697a18 into elastic:main Apr 5, 2023
@LaZyDK LaZyDK deleted the umbrella-revert-multiline branch April 5, 2023 06:59
@elasticmachine
Copy link

Package cisco_umbrella - 1.9.2 containing this change is available at https://epr.elastic.co/search?package=cisco_umbrella

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants