Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_workspace] Set event categorization for Token data stream. #5808

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

piyush-elastic
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

  • Set event categorization for Token data stream.

Integration release checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/google_workspace directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

asset
pipleine
static
system

@piyush-elastic piyush-elastic requested a review from a team as a code owner April 6, 2023 09:40
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Apr 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-06T09:44:27.167+0000

  • Duration: 28 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 112
Skipped 0
Total 112

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (14/14) 💚
Files 100.0% (14/14) 💚
Classes 100.0% (14/14) 💚
Methods 100.0% (179/179) 💚
Lines 94.469% (4560/4827) 👍 3.241
Conditionals 100.0% (0/0) 💚

@terrancedejesus terrancedejesus self-requested a review April 6, 2023 13:03
Copy link
Contributor

@terrancedejesus terrancedejesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. IAM event category verified for token data stream.

@jamiehynds
Copy link

@P1llus would you mind taking quick look at this one? Need to ensure the categorisation is added prior to 8.8 to ensure new Workspace rules work.

@P1llus P1llus merged commit 3f60a68 into elastic:main Apr 18, 2023
@elasticmachine
Copy link

Package google_workspace - 2.5.1 containing this change is available at https://epr.elastic.co/search?package=google_workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants