Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11Y][CoreDNS] Fix coredns reference error in overview dashboard #5814

Merged
merged 3 commits into from
Apr 12, 2023
Merged

[O11Y][CoreDNS] Fix coredns reference error in overview dashboard #5814

merged 3 commits into from
Apr 12, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Apr 6, 2023 •
edited
Loading

  • Bug

What does this PR do?

Resolve below reference error in visualizations.

Could not find reference for kibanaSavedObjectMeta.searchSourceJSON.index

image

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Visualizations don't have any errors.
  • Aggregations are intact and showing expected results.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner April 6, 2023 16:33
@kush-elastic kush-elastic added Integration:CoreDNS bug Something isn't working Team:Service-Integrations Label for the Service Integrations team labels Apr 6, 2023
@elasticmachine
Copy link

elasticmachine commented Apr 6, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-07T05:42:40.679+0000

  • Duration: 14 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 13
Skipped 0
Total 13

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 6, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (2/2) 💚 3.177
Classes 100.0% (2/2) 💚 3.177
Methods 95.455% (21/22) 👍 3.336
Lines 85.492% (165/193) 👎 -5.782
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor

@rajvi-elastic , please complete the peer review first.

@kush-elastic kush-elastic self-requested a review April 10, 2023 05:05
kush-elastic
kush-elastic approved these changes Apr 10, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

agithomas
agithomas approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit c5cd428 into elastic:main Apr 12, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kush-elastic kush-elastic kush-elastic approved these changes

@agithomas agithomas agithomas approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Integration:CoreDNS Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rajvi-patel-22 @elasticmachine @agithomas @kush-elastic