Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System/Windows/Winlog] Document 21 Event ID clause limit under certain situations #5838

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Apr 10, 2023

What does this PR do?

  • Add documentation around case where the event ID clause limit is lower than what is claimed by current docs.
  • Add additional documentation for workaround when event ID clause limit is exceeded.
  • Formatting and cleanup per elastic-package

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • [ ] I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

…in situations

- Add documentation around case where the event ID clause limit is lower than what is
claimed by current docs.
- Add additional documentation for workaround when event ID clause limit is exceeded.
- Formatting and cleanup per elastic-package
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Apr 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-10T17:51:29.045+0000

  • Duration: 17 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 276
Skipped 0
Total 276

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (7/7) 💚
Files 91.667% (11/12)
Classes 91.667% (11/12)
Methods 72.832% (126/173)
Lines 95.033% (7883/8295)
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson merged commit 5b38cf2 into elastic:main Apr 12, 2023
@taylor-swanson taylor-swanson deleted the issue/5835-document-21-event-id-limit branch April 12, 2023 17:51
@elasticmachine
Copy link

Package system - 1.25.3 containing this change is available at https://epr.elastic.co/search?package=system

@elasticmachine
Copy link

Package windows - 1.19.2 containing this change is available at https://epr.elastic.co/search?package=windows

@elasticmachine
Copy link

Package winlog - 1.13.1 containing this change is available at https://epr.elastic.co/search?package=winlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[System/Windows/Winlog] Document 21 Event ID clause limit under certain situations
4 participants