Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[o365] New field detected: FileSizeBytes #5840

Merged
merged 4 commits into from
Apr 18, 2023
Merged

[o365] New field detected: FileSizeBytes #5840

merged 4 commits into from
Apr 18, 2023

Conversation

nicpenning
Copy link
Contributor

An unknown field of o365.audit.FileSizeBytes was found in my logs when trying to reindex some conflict field indices into a new index.

Sadly, M$ does not appear to have these fields documented in their schema here: https://learn.microsoft.com/en-us/office/office-365-management-api/office-365-management-activity-api-schema

Furthermoore, it is much to difficult to get a raw event so I don't have a sample. Perhaps someone else out there can share a o365 Audit document from the SharePointFileOperation in event.code.

  • Enhancement

What does this PR do?

Add new FileSizeBytes field to make sure it is properly mapped.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

An unknown field of o365.audit.FileSizeBytes was found in my logs when trying to reindex some conflict field indices into a new index.

Sadly, M$ does not appear to have these fields documented in their schema here: https://learn.microsoft.com/en-us/office/office-365-management-api/office-365-management-activity-api-schema

Furthermoore, it is much to difficult to get a raw event so I don't have a sample. Perhaps someone else out there can share a o365 Audit document from the SharePointFileOperation in event.code.
@nicpenning nicpenning requested a review from a team as a code owner April 10, 2023 18:26
@elasticmachine
Copy link

elasticmachine commented Apr 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-18T00:24:00.095+0000

  • Duration: 14 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
Copy link
Contributor

efd6 commented Apr 17, 2023

/test

@efd6
Copy link
Contributor

efd6 commented Apr 17, 2023

Need to regenerate docs.

[2023-04-17T04:50:38.292Z] README.md is outdated. Rebuild the package with 'elastic-package build'
[2023-04-17T04:50:38.292Z] --- want
[2023-04-17T04:50:38.292Z] +++ got
[2023-04-17T04:50:38.292Z] @@ -250,2 +250,3 @@
[2023-04-17T04:50:38.292Z]  | o365.audit.ExternalAccess |  | boolean |
[2023-04-17T04:50:38.292Z] +| o365.audit.FileSizeBytes |  | long |
[2023-04-17T04:50:38.292Z]  | o365.audit.GroupName |  | keyword |
[2023-04-17T04:50:38.292Z] Error: checking package failed: checking readme files are up-to-date failed: files do not match

@nicpenning
Copy link
Contributor Author

Made a quick update, will that work?

@efd6
Copy link
Contributor

efd6 commented Apr 18, 2023

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (16/16) 💚 8.475
Lines 82.155% (732/891) 👎 -8.644
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit 5c759e5 into elastic:main Apr 18, 2023
@nicpenning nicpenning deleted the patch-7 branch April 18, 2023 02:27
@elasticmachine
Copy link

Package o365 - 1.14.1 containing this change is available at https://epr.elastic.co/search?package=o365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants