Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for a field data #5868

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Apr 12, 2023

  • Bug

What does this PR do?

This PR fix the data for a field i.e cockroachdb.status.up.value_description, this was getting set properly when the service is up, but for the case when service was down, this was not populating or pipeline was not setting the value for this field.
It was due to some typos in pipeline script, which is fixed by this PR.

Checklist

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar marked this pull request as ready for review April 12, 2023 08:53
@ritalwar ritalwar requested a review from a team as a code owner April 12, 2023 08:53
@elasticmachine
Copy link

elasticmachine commented Apr 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-12T08:47:49.540+0000

  • Duration: 15 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (3/4)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar merged commit 5f0784e into elastic:main Apr 12, 2023
@elasticmachine
Copy link

Package cockroachdb - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=cockroachdb

@andrewkroh andrewkroh added the Integration:cockroachdb CockroachDB Metrics label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:cockroachdb CockroachDB Metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants