cloudflare_logpush: fix mapping of url fields #5904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
Previously the url fields were being populated by the referrer URL parts in the http_request datastream and the request fields were incompletely filled in the firewall_events datastream. The use of the uri_parts processor to populate the url fields is a little troubling in the http_request datastream as the field used, ClientRequestURI, is not a URL and is arguably not even a URI without the context of the other ClientRequest* fields.
efd6
force-pushed
the
5849-cloudflare_logpush
branch
from
959b7d3
to
ea4f2c5
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
kcreddy
approved these changes
Apr 19, 2023
| @@ -115,6 +115,9 @@ | |||
| "preserve_duplicate_custom_fields" | |||
| ], | |||
| "url": { | |||
| "domain": "xyz.example.com", | |||
| "path": "/abc/checkout", | |||
| "query": "?sourcerer=(default%3A(id%3A!n%2CselectedPatterns%3A!(eqldemo%2C%27logs-endpoint.*-eqldemo%27%2C%27logs-system.*-eqldemo%27%2C%27logs-windows.*-eqldemo%27%2Cmetricseqldemo)))\u0026timerange=(global%3A(linkTo%3A!()%2Ctimerange%3A(from%3A%272022-04-05T00%3A00%3A01.199Z%27%2CfromStr%3Anow-24h%2Ckind%3Arelative%2Cto%3A%272022-04-06T00%3A00%3A01.200Z%27%2CtoStr%3Anow))%2Ctimeline%3A(linkTo%3A!()%2Ctimerange%3A(from%3A%272022-04-05T00%3A00%3A01.201Z%27%2CfromStr%3Anow-24h%2Ckind%3Arelative%2Cto%3A%272022-04-06T00%3A00%3A01.202Z%27%2CtoStr%3Anow)))", | |||
There was a problem hiding this comment.
In the ECS doc, ? symbol is being excluded from url.query. Maybe we could also exclude it to follow the standard.
|
Package cloudflare_logpush - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=cloudflare_logpush |
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Apr 22, 2023
Previously the url fields were being populated by the referrer URL parts in the http_request datastream and the request fields were incompletely filled in the firewall_events datastream. The use of the uri_parts processor to populate the url fields is a little troubling in the http_request datastream as the field used, ClientRequestURI, is not a URL and is arguably not even a URI without the context of the other ClientRequest* fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously the url fields were being populated by the referrer URL parts in the http_request datastream and the request fields were incompletely filled in the firewall_events datastream.
The use of the uri_parts processor to populate the url fields is a little troubling in the http_request datastream as the field used, ClientRequestURI, is not a URL and is arguably not even a URI without the context of the other ClientRequest* fields.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots