Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ti_misp: harmonise distribution type to long #5908

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 18, 2023

What does this PR do?

There was a type mapping conflict between misp.event.distribution in the
two datastreams. The numeric type was chosen over the keyword since in
the MISP documentation the distribution value is an ordered entity, so
this make the fields use as such possible in ES.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Apr 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-18T07:52:12.028+0000

  • Duration: 14 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

There was a type mapping conflict between misp.event.distribution in the
two datastreams. The numeric type was chosen over the keyword since in
the MISP documentation the distribution value is an ordered entity, so
this make the fields use as such possible in ES.
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (30/30) 💚
Lines 85.463% (535/626) 👎 -8.855
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review April 18, 2023 08:45
@efd6 efd6 requested a review from a team as a code owner April 18, 2023 08:45
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit c8cd89b into elastic:main Apr 18, 2023
@elasticmachine
Copy link

Package ti_misp - 1.12.1 containing this change is available at https://epr.elastic.co/search?package=ti_misp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:MISP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants