Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[InfluxDB] Add additional dimension field for advstatus datastream #5920

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Apr 19, 2023

Type of change

  • Bug

What does this PR do?

Add additional dimension field to advstatus datastream under influxDB

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@agithomas agithomas requested a review from a team as a code owner April 19, 2023 07:30
@agithomas agithomas changed the title Issue 5919 [InfluxDB] Add additional dimension field for advstatus datastream Apr 19, 2023
@elasticmachine
Copy link

elasticmachine commented Apr 19, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-20T07:01:12.122+0000

  • Duration: 17 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 19, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (6/8) 👎 -20.238
Lines 100.0% (0/0) 💚 7.566
Conditionals 100.0% (0/0) 💚

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "0.5.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version should be 0.4.1 for Bugfix.

Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agithomas agithomas merged commit af378cb into elastic:main Apr 20, 2023
@elasticmachine
Copy link

Package influxdb - 0.4.1 containing this change is available at https://epr.elastic.co/search?package=influxdb

daixque pushed a commit to daixque/integrations that referenced this pull request Apr 21, 2023
agithomas added a commit to agithomas/integrations that referenced this pull request Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[InfluxDB] Add labels.level as dimension field for advstatus datastream
4 participants