-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crowdstrike - Fix process.uptime and LocalAddressIP4 parsing #5957
Merged
kcreddy
merged 9 commits into
elastic:main
from
andrewkroh:bugfix/crowdstrike/pipeline-errors
May 15, 2023
Merged
crowdstrike - Fix process.uptime and LocalAddressIP4 parsing #5957
kcreddy
merged 9 commits into
elastic:main
from
andrewkroh:bugfix/crowdstrike/pipeline-errors
May 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two errors observed while parsing data from CrowdStrike FDR. Processor 'convert' with tag '' failed with message '192.168.1.129 192.168.1.35' is not an IP string literal. Processor 'conditional' with tag 'process-uptime' failed with message cannot implicitly cast def [int] to java.lang.String
🌐 Coverage report
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
efd6
reviewed
May 1, 2023
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
efd6
reviewed
May 4, 2023
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
efd6
approved these changes
May 7, 2023
andrewkroh
commented
May 8, 2023
packages/crowdstrike/data_stream/fdr/_dev/test/pipeline/test-fdr.log-expected.json
Outdated
Show resolved
Hide resolved
packages/crowdstrike/data_stream/fdr/_dev/test/pipeline/test-data.log-expected.json
Outdated
Show resolved
Hide resolved
andrewkroh
commented
May 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package crowdstrike - 1.12.1 containing this change is available at https://epr.elastic.co/search?package=crowdstrike |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes two errors observed while parsing data from CrowdStrike FDR.
Checklist
changelog.yml
file.