Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crowdstrike - Fix process.uptime and LocalAddressIP4 parsing #5957

Merged
merged 9 commits into from
May 15, 2023

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Apr 21, 2023

What does this PR do?

This fixes two errors observed while parsing data from CrowdStrike FDR.

Processor 'convert' with tag '' failed with message '192.168.1.129 192.168.1.35' is not an IP string literal.
Processor 'conditional' with tag 'process-uptime' failed with message cannot implicitly cast def [int] to java.lang.String

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

This fixes two errors observed while parsing data from CrowdStrike FDR.

    Processor 'convert' with tag '' failed with message '192.168.1.129 192.168.1.35' is not an IP string literal.
    Processor 'conditional' with tag 'process-uptime' failed with message cannot implicitly cast def [int] to java.lang.String
@elasticmachine
Copy link

elasticmachine commented Apr 21, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-11T07:10:24.658+0000

  • Duration: 14 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 16
Skipped 0
Total 16

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 21, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (9/9) 💚 2.894
Classes 100.0% (9/9) 💚 2.894
Methods 100.0% (56/56) 💚 7.512
Lines 95.207% (2781/2921) 👍 3.187
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy marked this pull request as ready for review April 24, 2023 16:53
@kcreddy kcreddy requested a review from a team as a code owner April 24, 2023 16:53
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Member Author

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcreddy kcreddy merged commit 85ee85e into elastic:main May 15, 2023
1 check passed
@elasticmachine
Copy link

Package crowdstrike - 1.12.1 containing this change is available at https://epr.elastic.co/search?package=crowdstrike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:Crowdstrike
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants