Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ti_misp: add toggle to enable request tracing #5965

Merged
merged 2 commits into from Apr 26, 2023
Merged

ti_misp: add toggle to enable request tracing #5965

merged 2 commits into from Apr 26, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 23, 2023

What does this PR do?

Adds an advanced option to enable http request trace logging for debugging purposes and bumps kibana constraint to 8.5.0 which is when the request tracer feature was introduced to Agent.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Apr 23, 2023
@efd6
ti_misp: add toggle to enable request tracing
4e16874 
Add an advanced option to enable http request trace logging for
debugging purposes.

Bump kibana constraint to 8.5.0 which is when the request
tracer feature was introduced to Agent.
@elasticmachine
Copy link

elasticmachine commented Apr 23, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-26T01:18:57.078+0000

  • Duration: 16 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 23, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 100.0% (30/30) 💚
Lines 85.463% (535/626) ❕
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review April 23, 2023 23:59
@efd6 efd6 requested a review from a team as a code owner April 23, 2023 23:59
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 mentioned this pull request Apr 24, 2023
Closed
@efd6 @kgeller
Update packages/ti_misp/data_stream/threat/agent/stream/httpjson.yml.hbs
5042ba7 
Co-authored-by: Kylie Meli <kylie.geller@gmail.com>
@efd6 efd6 requested a review from kgeller April 26, 2023 01:34
kcreddy
kcreddy approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit 026db7b into elastic:main Apr 26, 2023
3 checks passed
@elasticmachine
Copy link

Package ti_misp - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=ti_misp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

@kgeller kgeller Awaiting requested review from kgeller

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:MISP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@efd6 @elasticmachine @kgeller @kcreddy