-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS][Lambda] Add dimension fields for TSDB support #5973
Conversation
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
🌐 Coverage report
|
description: Lambda function name. | ||
- name: Resource | ||
type: keyword | ||
dimension: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is a meaning of the Resource
field? From the issue description I got an impression that name of function and version uniquely identify the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, what is the difference between those documents?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. The only difference from comparing these two documents is than one has the dimension resource and the other has not, but even the values for the metrics are exactly the same @tetianakravchenko I am not sure if I should let be overwritten then or how to make sure that the one with the resource
set will be the final document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elastic/obs-cloud-monitoring is it an expected behavior that there are 2 documents with the same data?
@constanca-m so far it seems for me that generic pattern for aws package datasreams is to add all fields that are part of dimensions.*
object, so I would keep it, I think we shouldn't make a decision on what should be overwritten
Package aws - 1.36.7 containing this change is available at https://epr.elastic.co/search?package=aws |
What does this PR do?
Add dimension fields to Lambda datastream.
Details
The lambda function name is unique per region within an account. Since the lambda function can have different versions, we need to make that a dimension as well. As the version affects the resource name, this will be our last dimension.
There was not a change in the number of documents after enabling TSDB:
Tested with one account, one lambda function with two different versions.
Checklist
changelog.yml
file.How to test this PR locally
Refer to #5970
Related issues