Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_umbrella] Add Mobile Devices as hosts #6019

Merged
merged 3 commits into from
May 9, 2023

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Apr 27, 2023

What does this PR do?

It will add a new identity type "Mobile Devices" as a host.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@LaZyDK LaZyDK requested a review from a team as a code owner April 27, 2023 15:10
@elasticmachine
Copy link

elasticmachine commented Apr 27, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-08T13:23:10.178+0000

  • Duration: 14 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 10
Skipped 0
Total 10

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 8, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 95.238% (20/21) 👍 4.329
Lines 94.805% (511/539) 👍 5.916
Conditionals 100.0% (0/0) 💚

@P1llus
Copy link
Member

P1llus commented May 8, 2023

/test

@P1llus
Copy link
Member

P1llus commented May 8, 2023

/test

@P1llus P1llus merged commit 6eb73f3 into elastic:main May 9, 2023
1 check passed
@elasticmachine
Copy link

Package cisco_umbrella - 1.10.1 containing this change is available at https://epr.elastic.co/search?package=cisco_umbrella

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants