Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vulnerability Management] Update CloudFormation template ElasticAgentVersion #6034

Conversation

amirbenun
Copy link
Contributor

What does this PR do?

The meaning of ElasticAgentVersion parameter has changed as part of the new cloudformation template.
The template used to expect a value in the form of elastic-agent-KIBANA_VERSION-linux-arm64, and as of the new template it only expects KIBANA_VERSION.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@amirbenun amirbenun added the enhancement New feature or request label Apr 30, 2023
@amirbenun amirbenun requested a review from a team as a code owner April 30, 2023 11:02
@elasticmachine
Copy link

elasticmachine commented Apr 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-02T13:17:05.027+0000

  • Duration: 14 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 30, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👎 -35.759
Lines 100.0% (0/0) 💚 0.465
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this change is dedicated for 8.9.0 please introduce a new version of 1.4.0-preview1 and change the condition to 8.9.0

@kfirpeled
Copy link
Contributor

Please do not merge this before the 1st QA cycle is over

- description: Send short notation of ElasticAgentVersion
type: enhancement
link: https://github.com/elastic/integrations/pull/6034
- version: "1.3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the preview from 1.3.0 means it will be published right after this will be merged.
We plan to release the integration on the release date of 8.8.0
please leave the preview suffix for 1.3.0

@amirbenun amirbenun merged commit e96e02c into elastic:main May 2, 2023
1 check passed
@amirbenun amirbenun deleted the vuln-mgmt-update-cloudformation-8.9.0-2023-04-30-08-56-40 branch May 2, 2023 13:36
@elasticmachine
Copy link

Package cloud_security_posture - 1.4.0-preview1 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.4.0-preview2 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.4.0-preview21 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.4.0-preview22 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@kfirpeled kfirpeled added the Team:Cloud Security Label for the Cloud Security team label Jun 26, 2023
@elasticmachine
Copy link

Package cloud_security_posture - 1.4.0-preview23 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Cloud Security Label for the Cloud Security team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants