Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimecast: check ttp URL source IP values for type conformity #6046

Merged
merged 1 commit into from
May 3, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 1, 2023

What does this PR do?

Checks ttp URL source IP values for type conformity. Also fix field mapping name for sourceIp. This is not breaking since the currently used name, sourceIP would never have been set.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working Team:Security-External Integrations Integration:Mimecast Mimecast integration labels May 1, 2023
@efd6 efd6 self-assigned this May 1, 2023
Also fix field mapping name for sourceIp. This is not breaking since
the currently used name, sourceIP would never have been set.
@elasticmachine
Copy link

elasticmachine commented May 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-01T23:11:16.303+0000

  • Duration: 19 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 56
Skipped 0
Total 56

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 100.0% (8/8) 💚
Classes 100.0% (8/8) 💚
Methods 95.122% (117/123) 👎 -4.878
Lines 88.725% (1267/1428) 👍 3.635
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review May 1, 2023 23:45
@efd6 efd6 requested a review from a team as a code owner May 1, 2023 23:45
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit e81d9e8 into elastic:main May 3, 2023
1 check passed
@elasticmachine
Copy link

Package mimecast - 1.8.1 containing this change is available at https://epr.elastic.co/search?package=mimecast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:Mimecast Mimecast integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants