Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS][EBS] Add dimensions fields. #6062

Merged
merged 2 commits into from
May 3, 2023

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented May 2, 2023

What does this PR do?

Add dimension fields to EBS datastream.

Details

Each EBS resource has a volume ID that is unique within a region in some account. This makes the combination (volume id, region, account) unique. There is no change in the number of documents after enabling TSDB:

image

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Refer to #6061

Related issues

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m mentioned this pull request May 2, 2023
5 tasks
@elasticmachine
Copy link

elasticmachine commented May 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-02T14:12:03.568+0000

  • Duration: 57 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 86.131% (236/274) 👍 61.131
Lines 85.925% (7387/8597) 👎 -14.075
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor

Can you please validate - if cloud.availability_zone be a dimension filed ?

Reference : https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/ebs-creating-volume.html , Step 8.

@constanca-m constanca-m merged commit 03d9094 into elastic:main May 3, 2023
1 check passed
@constanca-m constanca-m deleted the ebs-add-dimensions branch May 3, 2023 15:25
@elasticmachine
Copy link

Package aws - 1.34.0 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants