Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Apache] [TSDB] Added dimension fields for status datastream #6077

Merged
merged 4 commits into from
May 5, 2023
Merged

[Apache] [TSDB] Added dimension fields for status datastream #6077

merged 4 commits into from
May 5, 2023

Conversation

agithomas
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

Added metric_type mapping for partition datastream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@agithomas agithomas mentioned this pull request May 3, 2023
Closed
5 tasks
@elasticmachine
Copy link

elasticmachine commented May 3, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-03T16:15:45.529+0000

  • Duration: 15 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 3, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 50.0% (2/4) 👎 -46.952
Classes 50.0% (2/4) 👎 -46.952
Methods 70.0% (28/40) 👎 -21.658
Lines 70.234% (210/299) 👎 -21.757
Conditionals 100.0% (0/0) 💚

@agithomas agithomas marked this pull request as ready for review May 3, 2023 14:36
@agithomas agithomas requested a review from a team as a code owner May 3, 2023 14:36
@agithomas agithomas changed the title Added dimension fields for status datastream [Apache] [TSDB] Added dimension fields for status datastream May 3, 2023
ritalwar
ritalwar approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit c518788 into elastic:main May 5, 2023
@elasticmachine
Copy link

Package apache - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=apache

@andrewkroh andrewkroh added the Integration:apache Apache HTTP Server label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritalwar ritalwar ritalwar approved these changes

Assignees
No one assigned
Labels
Integration:apache Apache HTTP Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@agithomas @elasticmachine @ritalwar @andrewkroh