-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[httpjson] Enable request tracer on obs service integrations #6160
Conversation
🌐 Coverage report
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. No duplicate var definitions found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But it'd be great if someone else from my team also takes a look as I'm still new to integrations.
@bhapas : What is criticality of this change ? |
@ishleenk17 This change would enable the users of the integration be able to enable request-response tracing between the host and the agent. This would be helpful in debugging the issues as these logs are part of agent diagnostics. Not sure about the big jump though... We are already on the 8.8 of stack and any new feature in beats shall only be on 8.7 (8.7.2)or above. What else do you think would cause an issue? |
Package apache - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=apache |
Package ceph - 0.9.0 containing this change is available at https://epr.elastic.co/search?package=ceph |
Package citrix_adc - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=citrix_adc |
Package golang - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=golang |
Package nginx - 1.13.0-beta containing this change is available at https://epr.elastic.co/search?package=nginx |
Package php_fpm - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=php_fpm |
Package salesforce - 0.9.0 containing this change is available at https://epr.elastic.co/search?package=salesforce |
What does this PR do?
This PR enables request tracer on all OBS Service Integrations with
httpjson
input.Sets the minimum Kibana version to
8.7.1
Enables the request tracer in system tests.
Checklist
changelog.yml
file.Reviewer's checklist
Related