Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AWS CloudWatch logs via S3 option #6247

Merged
merged 7 commits into from Aug 25, 2023

Conversation

tdancheva
Copy link
Contributor

@tdancheva tdancheva commented May 18, 2023

What does this PR do?

It removes the option to collect logs using aws-s3 input marked as deprecated.

Behavior on upgrade:

  1. Update integration policy on
    The option disappears after the upgrade, the datastream remains but stops collecting data.
  2. Update integration policy off
    The option remains, since the policy is unchanged it keeps functioning and ingesting data

Sidenote: This input configuration only included SQS queue ARN input field requiring the whole CloudWatch-S3-SQS chain to be configured i.e. there was no option to provide a standalone S3 bucket.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

Check that the "Collect Cloudwatch Logs via S3 options" is not shown anymore when the policy is upgraded, and the integration works as expected.

Screenshots

@elasticmachine
Copy link

elasticmachine commented May 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-23T13:54:00.568+0000

  • Duration: 53 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 208
Skipped 4
Total 212

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 18, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -2.206
Classes 94.444% (17/18) 👎 -2.206
Methods 85.953% (257/299) 👎 -5.91
Lines 86.024% (7509/8729) 👎 -2.295
Conditionals 100.0% (0/0) 💚

@tdancheva tdancheva marked this pull request as ready for review June 12, 2023 16:24
@tdancheva tdancheva requested a review from a team as a code owner June 12, 2023 16:24
@tdancheva
Copy link
Contributor Author

The "Changelog" modal is available from version 8.8.x, so we would need to bump the Kibana version to be able to see it. It was not possible to backport it (see PR, we are not shipping more minors for 8.7). Should I bump the whole AWS package and ship this from 8.8.0?

@elasticmachine
Copy link

💚 Build Succeeded

@botelastic
Copy link

botelastic bot commented Jul 13, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jul 13, 2023
@botelastic botelastic bot removed the Stalled label Jul 18, 2023
@botelastic
Copy link

botelastic bot commented Aug 17, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Aug 17, 2023
@tdancheva tdancheva requested a review from a team as a code owner August 21, 2023 12:16
@botelastic botelastic bot removed the Stalled label Aug 21, 2023
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdancheva tdancheva merged commit 1f978bd into elastic:main Aug 25, 2023
4 checks passed
@elasticmachine
Copy link

Package aws - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=aws

gizas pushed a commit that referenced this pull request Sep 5, 2023
* Remove AWS CloudWatch logs via S3 option

* Update changelog entry

* Make Changelog more detailed for users that might be using the S3 datastream

---------

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants