Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fortinet_fortigate] Fix syslog KV split to take into account quoted values. #6276

Merged
merged 2 commits into from
May 22, 2023

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented May 22, 2023

What does this PR do?

Fix syslog KV split to take into account quoted values and be more defensive.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@marc-gr marc-gr added Team:Security-External Integrations Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. bugfix labels May 22, 2023
@marc-gr marc-gr requested a review from a team as a code owner May 22, 2023 08:24
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented May 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-22T08:31:51.177+0000

  • Duration: 16 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (38/38) 💚
Lines 90.952% (1156/1271) 👎 -2.636
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit cb00b7b into elastic:main May 22, 2023
1 check passed
@marc-gr marc-gr deleted the fix/fortigate-kv-parsing branch May 22, 2023 11:16
@elasticmachine
Copy link

Package fortinet_fortigate - 1.10.1 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

@andrewkroh andrewkroh added Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs and removed Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants