Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memcached Integration - Updated documentation to fix punctuations #6303

Merged
merged 3 commits into from
May 25, 2023

Conversation

muthu-mps
Copy link
Contributor

  • Bug

Fixes - #5997

How to test this PR locally

Install the Memcached integration and verify metrics collection.
Verify the documentation change is getting reflected.

Related issues

@elasticmachine
Copy link

elasticmachine commented May 24, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-25T10:57:12.762+0000

  • Duration: 15 min 16 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 24, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (3/4)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@muthu-mps muthu-mps self-assigned this May 24, 2023
@muthu-mps muthu-mps added the Team:Service-Integrations Label for the Service Integrations team label May 24, 2023
@muthu-mps muthu-mps marked this pull request as ready for review May 24, 2023 10:11
@muthu-mps muthu-mps requested a review from a team as a code owner May 24, 2023 10:11
@muthu-mps muthu-mps requested a review from a team as a code owner May 25, 2023 10:56
@muthu-mps muthu-mps merged commit 8dd1cea into elastic:main May 25, 2023
3 checks passed
Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can we rename the PR title to:

[Memcached] Update documentation to fix punctuation

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "0.4.1"
changes:
- description: Updated documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Updated documentation
- description: Update documentation

https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches?h=v2.36.1#n181

Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behavior.

Commit messages, changelog, PR titles, etc. ideally should follow this.

@elasticmachine
Copy link

Package memcached - 0.4.1 containing this change is available at https://epr.elastic.co/search?package=memcached

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Memcached] Update the documentation
4 participants