Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sophos_central] Fix timestamp parsing and update package-spec version to 2.7.0 #6309

Merged

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented May 24, 2023

What does this PR do?

  • Switch formats from epoch_* to UNIX*
  • Switch one instance of UNIX to UNIX_MS (sophos_central.alert.data.threat_id.date), as incoming value was expressed in milliseconds
  • Update package-spec version to 2.7.0
  • Regen test expected files

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package test

Related issues

  • Relates elastic/security-team#5870

…n to 2.7.0

- Switch formats from epoch_* to UNIX*
- Switch one instance of UNIX to UNIX_MS (sophos_central.alert.data.threat_id.date),
as incoming value was expressed in milliseconds
- Update package-spec version to 2.7.0
- Regen test expected files
@elasticmachine
Copy link

elasticmachine commented May 24, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-24T14:43:13.718+0000

  • Duration: 15 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 14
Skipped 0
Total 14

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 94.118% (32/34) 👎 -1.021
Lines 93.503% (993/1062) 👍 0.968
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review May 24, 2023 15:38
@taylor-swanson taylor-swanson requested a review from a team as a code owner May 24, 2023 15:38
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@taylor-swanson taylor-swanson merged commit 5e88632 into elastic:main May 30, 2023
3 checks passed
@taylor-swanson taylor-swanson deleted the pkg-spec-update-sophos-central branch May 30, 2023 13:26
@elasticmachine
Copy link

Package sophos_central - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=sophos_central

agithomas pushed a commit to agithomas/integrations that referenced this pull request Jun 5, 2023
…n to 2.7.0 (elastic#6309)

- Switch formats from epoch_* to UNIX*
- Switch one instance of UNIX to UNIX_MS (sophos_central.alert.data.threat_id.date),
as incoming value was expressed in milliseconds
- Update package-spec version to 2.7.0
- Regen test expected files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants