-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Set dimensions fields of Billing, SQS and SNS data streams #6311
[AWS] Set dimensions fields of Billing, SQS and SNS data streams #6311
Conversation
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
🌐 Coverage report
|
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
packages/aws/changelog.yml
Outdated
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "1.36.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: in #6365 we bumped minor version, here only patch one
why the difference? :)
Package aws - 1.38.4 containing this change is available at https://epr.elastic.co/search?package=aws |
* Add SQS dimensions. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Add SNS dimensions. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Add SNS dimensions. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Add Billing dimensions. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Update changelog. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Add 2 ecs dimension fields. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Remove cloud.availability_zone as dimension (not present) Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Update md. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> --------- Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
What does this PR do?
Set dimensions fields of Billing, SQS and SNS data streams.
Billing:
cloud.account.id
andServiceName1
work as a unique combination.SQS:
aws.dimensions.QueueName
andaws.sqs.queue.name
. From my understanding, when one of them is available, the other is as well (they come from"cloudwatch:GetMetricData"
), so only one of them was set as dimension (aws.dimensions.QueueName
).SNS:
Regarding ECS fields, more info can be found here #5193 (comment).
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Refer to #6293.
Related issues
Relates to #6293.