New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Add metric type to SNS, SQS and Billing data streams #6319
[AWS] Add metric type to SNS, SQS and Billing data streams #6319
Conversation
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can this PR be merged after code-owner review? |
packages/aws/changelog.yml
Outdated
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "1.36.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: in #6365 we bumped minor version, here only patch one
why the difference? :)
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Package aws - 1.40.0 containing this change is available at https://epr.elastic.co/search?package=aws |
* Add metric type to SNS. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Add metric type to SQS. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Add metric type to Billing. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Update changelog. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> * Update files. Signed-off-by: constanca-m <constanca.manteigas@elastic.co> --------- Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
What does this PR do?
Adds metric type to SNS, SQS and Billing data streams.
Billing:
From my understanding, most metrics are estimates, so they can go up and down. The ones that are not (
UnblendedCost
andUsageQuantity
) consider a specific time window.SNS:
Values are only considered for a specific time window, after that they reset for the next time window. This causes lots of ups and downs over time, and since the next value received for a specific field does not take into account the previous, all of them were considered gauge. Take this field (
NumberOfMessagesPublished.sum
) as an example:SQS:
Same logic was applied. Example of a gauge field that might look like a counter from the description is
messages.received
. When we visualize that metric, we can see that is in fact a gauge:Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Refer to #6293.
Related issues
Relates to #6293.