Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_ftd] Add rule, device and host ECS fields #6322

Merged
merged 9 commits into from
May 30, 2023

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented May 25, 2023

What does this PR do?

Adds test data for Cisco ISE pxGrid Endpoint Profile data.
Adds rule, host and device ECS fields.
Removes empty fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@LaZyDK LaZyDK requested a review from a team as a code owner May 25, 2023 15:21
@elasticmachine
Copy link

elasticmachine commented May 25, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-30T10:52:20.812+0000

  • Duration: 17 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 21
Skipped 0
Total 21

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@jamiehynds jamiehynds added the Integration:CiscoFTD Cisco FTD Firepower Threat Defense label May 25, 2023
@LaZyDK LaZyDK changed the title [cisco_ftd] Add rule ECS fields [cisco_ftd] Add rule, device and host ECS fields May 26, 2023
@kcreddy
Copy link
Contributor

kcreddy commented May 29, 2023

/test

@elasticmachine
Copy link

elasticmachine commented May 29, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.958
Classes 100.0% (1/1) 💚 2.958
Methods 100.0% (22/22) 💚 8.081
Lines 70.469% (1396/1981) 👎 -21.586
Conditionals 100.0% (0/0) 💚

LaZyDK and others added 2 commits May 30, 2023 06:00
…ne/default.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
…ne/default.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@efd6
Copy link
Contributor

efd6 commented May 30, 2023

/test

@efd6
Copy link
Contributor

efd6 commented May 30, 2023

/test

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit 3a84e2d into elastic:main May 30, 2023
3 checks passed
@elasticmachine
Copy link

Package cisco_ftd - 2.11.0 containing this change is available at https://epr.elastic.co/search?package=cisco_ftd

@LaZyDK LaZyDK deleted the ftd_rule_ecs branch June 1, 2023 09:10
agithomas pushed a commit to agithomas/integrations that referenced this pull request Jun 5, 2023
Also make null cleanup handle empty non-null values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:CiscoFTD Cisco FTD Firepower Threat Defense
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants