-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add condition
and processors
settings to SQL Input
#6358
Conversation
condition
and processors
settings to sql inputcondition
and processors
settings to SQL Input
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
@ishleenk17, Can you check this PR in sql input? |
4c5ad2b
to
4c5e751
Compare
FYI, this PR was a bit out of date, I've rebased and fixed the merge conflicts |
/test |
@BenB196 : Could you please elaborate on the need for conditions? |
Hi @ishleenk17 regarding the need for condition, suppose I have 2 SQL databases I want to query on 2 different servers, but they differ in some way that makes them require their own unique definition of the |
@BenB196 : This is a In this case, 2 SQL Input Integrations will point to 2 different hosts (databases) and due to 2 different datasets, the data will be mapped to the index created by a specific dataset (hence distinguishing between db1 and db2). For generic integrations (I see you have raised this for IIS etc), the conditions would make sense as dataset names are not taken as input from user. They are fixed. |
Hi @ishleenk17 I think there might be some confusion here, the issue this PR tries to solve isn't related to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take care of updating the processor link as mentioned in the comment.
Rest looks good!
Hi @ishleenk17, wanted to check to see if there was anything else blocking the PR? |
Thanks for the contribution. The PR is merged now. |
Package sql - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=sql |
Enhancement
What does this PR do?
This PR adds two (2) new field settings to the SQL Input integration.
condition
.host
metadata; ex;host.name
orhost.platform
.processors
.processors
to manipulate collected data before sending to Elasticsearch.Checklist
changelog.yml
file.Author's Checklist
condition
andprocessors
as "advanced" fields.Before Upgrade
After Upgrade (with Settings)
How to test this PR locally
Related issues
Screenshots