Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWS] Add agent.id field to be set as dimension for TSDB migration #6421

Merged
merged 5 commits into from Jun 8, 2023
Merged

[AWS] Add agent.id field to be set as dimension for TSDB migration #6421

merged 5 commits into from Jun 8, 2023

Conversation

constanca-m
Copy link
Contributor

What does this PR do?

The field agent.id needs to be set as dimension for TSDB migration. Reasoning for this can be found in the thread following the comment #5193 (comment)

Note: agent.id hasn't been added to all data streams yet, just to the ones that were migrated to TSDB already.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@constanca-m
Add agent.id as dimension
4220b7a 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m
Add agent.id as dimension
091598d 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m requested a review from a team as a code owner June 1, 2023 10:27
@constanca-m constanca-m self-assigned this Jun 1, 2023
@constanca-m
Update changelog
78c1c50 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine
Copy link

elasticmachine commented Jun 1, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-08T06:13:09.755+0000

  • Duration: 52 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 190
Skipped 4
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 1, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 85.921% (238/277) 👎 -14.079
Lines 85.925% (7387/8597) 👎 -4.896
Conditionals 100.0% (0/0) 💚

@constanca-m constanca-m mentioned this pull request Jun 1, 2023
Closed
agithomas
agithomas reviewed Jun 1, 2023
View reviewed changes
packages/aws/manifest.yml Outdated
@@ -1,7 +1,7 @@
format_version: 1.0.0
name: aws
title: AWS
version: 1.37.3
version: 1.38.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be ok to keep the version as 1.37.4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes on 1.37 are not related to TSDB, that is why I bumped to 1.30

@agithomas
Copy link
Contributor

Please confirm that you have verified the number of dimensions are within 16 , after making this change, for all datastreams?

@constanca-m
Copy link
Contributor Author

Please confirm that you have verified the number of dimensions are within 16 , after making this change, for all datastreams?

Yes @agithomas:
DynamoDB: 11
EBS: 4
ECS: 5
ELB: 7
Kinesis: 4
Lambda: 6
Natgateway: 4
Redshift: 11
Usage: 7

agithomas
agithomas approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@constanca-m constanca-m mentioned this pull request Jun 2, 2023
Closed
4 tasks
tommyers-elastic
tommyers-elastic approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

constanca-m and others added 2 commits June 8, 2023 08:10
@constanca-m
Merge branch 'main' into aws-add-agent-id
05ccda5
@constanca-m
Update files.
f8aa33e 
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m constanca-m merged commit e94623d into elastic:main Jun 8, 2023
3 checks passed
@constanca-m constanca-m deleted the aws-add-agent-id branch June 8, 2023 07:57
@elasticmachine
Copy link

Package aws - 1.42.0 containing this change is available at https://epr.elastic.co/search?package=aws

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@constanca-m @sodhikirti07
[AWS] Add agent.id field to be set as dimension for TSDB migration (#…
488e017 
…6421)

* Add agent.id as dimension

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

@tetianakravchenko tetianakravchenko Awaiting requested review from tetianakravchenko

Assignees

@constanca-m constanca-m

Labels
Integration:AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@constanca-m @elasticmachine @agithomas @tommyers-elastic