Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System] Enable tsdb by default for beta testing for all but core, network and process data_streams #6427

Merged
merged 3 commits into from Jun 1, 2023

Conversation

tetianakravchenko
Copy link
Contributor

What does this PR do?

This PR enables TSDB for System package by default.
Note:

elasticsearch:
  index_mode: "time_series"

is not set only for 3 data_stream: core, network and process. There will be created a dedicated PRs to add missing dimensions (for core) and metric_type (for process) and enable tsdb as a -beta.x version.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

… process data_streams

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

elasticmachine commented Jun 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-01T15:20:33.809+0000

  • Duration: 16 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 145
Skipped 0
Total 145

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 1, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 60.759% (48/79) 👎 -39.241
Lines 99.536% (2790/2803) 👍 8.708
Conditionals 100.0% (0/0) 💚

@tetianakravchenko
Copy link
Contributor Author

/test

@tetianakravchenko tetianakravchenko merged commit 086bd44 into elastic:main Jun 1, 2023
3 checks passed
@elasticmachine
Copy link

Package system - 1.32.0-beta containing this change is available at https://epr.elastic.co/search?package=system

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
…twork and process data_streams (#6427)

* enable tsdb by default for beta testing for all but core, network and process data_streams

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* fix PR link

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

---------

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants