Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y] [Nagios XI] Update field description for host and service data stream #6429

Conversation

milan-elastic
Copy link
Contributor

  • Bug

What does this PR do?

  • Update field description for host and service data streams fields.yml
  • Update README.md with descriptions.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@milan-elastic milan-elastic marked this pull request as ready for review June 1, 2023 14:07
@milan-elastic milan-elastic requested a review from a team as a code owner June 1, 2023 14:07
@elasticmachine
Copy link

elasticmachine commented Jun 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-02T05:09:11.425+0000

  • Duration: 15 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 40
Skipped 0
Total 40

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 97.059% (33/34)
Lines 95.23% (1138/1195)
Conditionals 100.0% (0/0) 💚

@milan-elastic
Copy link
Contributor Author

/test

Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milan-elastic milan-elastic merged commit 3e61ef0 into elastic:main Jun 2, 2023
3 checks passed
@elasticmachine
Copy link

Package nagios_xi - 0.5.1 containing this change is available at https://epr.elastic.co/search?package=nagios_xi

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
… stream (#6429)

* Update field description for host and service data stream

* Update changelog.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NagiosXI Integration] Add description for host and service datastream fields
4 participants