Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate dashboard "Azure Spring Cloud Logs Application Cloud Logs" to Lens #6435

Merged
merged 6 commits into from Jun 12, 2023
Merged

Migrate dashboard "Azure Spring Cloud Logs Application Cloud Logs" to Lens #6435

merged 6 commits into from Jun 12, 2023

Conversation

tdancheva
Copy link
Contributor

@tdancheva tdancheva commented Jun 1, 2023 •
edited

What does this PR do?

This PR migrates the "Azure Spring Cloud Logs Application Cloud Logs" dashboard in the Azure integration to Lens and applies some global recommendations for designing dashboards.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Before migration:

BEFORE_2

After migration:

AFTER_01_06_2

@elasticmachine
Copy link

elasticmachine commented Jun 1, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-12T14:13:09.335+0000

  • Duration: 14 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 1, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -13.636
Classes 86.364% (19/22) 👎 -13.636
Methods 83.333% (155/186) 👎 -16.667
Lines 84.935% (2802/3299) 👎 -14.544
Conditionals 100.0% (0/0) 💚

@tdancheva tdancheva added the enhancement New feature or request label Jun 7, 2023
@tdancheva tdancheva marked this pull request as ready for review June 7, 2023 14:58
@tdancheva tdancheva requested a review from a team as a code owner June 7, 2023 14:58
@zmoog zmoog requested a review from a team June 8, 2023 09:40
@tdancheva tdancheva merged commit 813629a into elastic:main Jun 12, 2023
3 checks passed
@elasticmachine
Copy link

Package azure - 1.5.16 containing this change is available at https://epr.elastic.co/search?package=azure

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@tdancheva @sodhikirti07
Migrate dashboard "Azure Spring Cloud Logs Application Cloud Logs" to…
1f8a49f 
… Lens (#6435)

* [Logs Azure] Azure Spring Cloud Logs Application Cloud Logs - Migration to Lens

* Fix titles

* Remove global dashboard filters and only use panel filter - latest guidelines

* Changelog and manifest

* Manifest and changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@drewdaemon drewdaemon drewdaemon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tdancheva @elasticmachine @zmoog @drewdaemon