[AWS] Use aws.dimensions.DBInstanceIdentifier as database instance identifier in the RDS dashboard
#6440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmoog
added
enhancement
zmoog
changed the title
aws.dimensions.DBInstanceIdentifier as database instance identifier in the RDS dashboard
kaiyan-sheng
approved these changes
Jun 1, 2023
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
Previously we used `aws.rds.db_instance.identifier` as the field to identify database instances in the RDS dashboard. However, since the CloudWatch metricset collects this field as metadata calling the DescribeDBInstances API [1] calls, transient problems with permissions or configuration issues may prevent the dashboard from displaying data. We decided to replace `aws.rds.db_instance.identifier` with `aws.dimensions.DBInstanceIdentifier` since CloudWatch returns this dimension with the metrics values. [1]: https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_DescribeDBInstances.html
zmoog
force-pushed
the
zmoog/rds-dashboard-use-dbinstanceidentifier-dimension
branch
from
ccc46f0
to
5c0f1e5
Compare
drewdaemon
approved these changes
Jun 2, 2023
|
Package aws - 1.40.2 containing this change is available at https://epr.elastic.co/search?package=aws |
sodhikirti07
pushed a commit
that referenced
this pull request
Jun 15, 2023
…identifier in the RDS dashboard (#6440) * Use aws.dimensions.DBInstanceIdentifier as DB identifier Previously we used `aws.rds.db_instance.identifier` as the field to identify database instances in the RDS dashboard. However, since the CloudWatch metricset collects this field as metadata calling the DescribeDBInstances API [1] calls, transient problems with permissions or configuration issues may prevent the dashboard from displaying data. We decided to replace `aws.rds.db_instance.identifier` with `aws.dimensions.DBInstanceIdentifier` since CloudWatch returns this dimension with the metrics values. [1]: https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_DescribeDBInstances.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace
aws.rds.db_instance.identifierwithaws.dimensions.DBInstanceIdentifieras the field to identify database instances in the RDS dashboard.Why?
Previously we used
aws.rds.db_instance.identifieras the field to identify database instances in the RDS dashboard.However, since the CloudWatch metricset collects the
aws.rds.db_instance.*as metadata calling the DescribeDBInstances API calls, transient problems with permissions or other configuration issues may prevent the dashboard from displaying data.We decided to replace
aws.rds.db_instance.identifierwithaws.dimensions.DBInstanceIdentifiersince CloudWatch returns this dimension with the metrics values.Checklist
changelog.ymlfile.Screenshots