Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][AWS S3 Storage Lens] Migrate dashboard visualizations to lens in Kibana 8.7.1 #6455

Merged
merged 3 commits into from Jun 7, 2023
Merged

[O11y][AWS S3 Storage Lens] Migrate dashboard visualizations to lens in Kibana 8.7.1 #6455

merged 3 commits into from Jun 7, 2023

Conversation

kush-elastic
Copy link
Collaborator

  • Enhancement

What does this PR do?

  • Manually migrate AWS S3 Storage Lens Overview visualizations to the lens in the current Kibana version 8.7.1 itself.

  • Statistics for S3 Storage Lens Overview Lens migration:

AWS Cloudtrail Dashboards Before Migration       After Migration      
  Markdown Search Lens Visualization Markdown Search Lens Visualization
[Metrics AWS] S3 Storage Lens Overview 4 0 3 13 4 0 16 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.7.1 itself.

Related issues

Note:

Since the current screenshot is not updated, please refer the below Before Migrated screenshot to compare!
image

@kush-elastic kush-elastic added enhancement New feature or request Integration:AWS labels Jun 2, 2023
@kush-elastic kush-elastic self-assigned this Jun 2, 2023
@kush-elastic kush-elastic marked this pull request as ready for review June 2, 2023 13:08
@kush-elastic kush-elastic requested review from a team as code owners June 2, 2023 13:08
@elasticmachine
Copy link

elasticmachine commented Jun 2, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-07T10:09:50.300+0000

  • Duration: 48 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 190
Skipped 4
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 2, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 85.921% (238/277) 👎 -9.913
Lines 85.925% (7387/8597) 👍 0.604
Conditionals 100.0% (0/0) 💚

harnish-elastic
harnish-elastic approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

harnish-elastic
harnish-elastic approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

milan-elastic
milan-elastic approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic harnish-elastic mentioned this pull request Jun 7, 2023
Closed
5 tasks
@kush-elastic
Merge branch 'main' of https://github.com/kush-elastic/integrations i…
f824c91 
…nto lens_migration-aws-s3-storage-lens

Conflicts:
	packages/aws/changelog.yml
	packages/aws/manifest.yml
@kush-elastic kush-elastic merged commit 5c28f32 into elastic:main Jun 7, 2023
3 checks passed
@elasticmachine
Copy link

Package aws - 1.40.6 containing this change is available at https://epr.elastic.co/search?package=aws

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@kush-elastic @sodhikirti07
[O11y][AWS S3 Storage Lens] Migrate dashboard visualizations to lens …
e4e92a7 
…in Kibana 8.7.1 (#6455)

* migrate s3 storage lens visualization to lens

* update changelog.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@drewdaemon drewdaemon drewdaemon approved these changes

@harnish-elastic harnish-elastic harnish-elastic approved these changes

@milan-elastic milan-elastic milan-elastic approved these changes

Assignees

@kush-elastic kush-elastic

Labels
enhancement New feature or request Integration:AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][AWS S3 Storage Lens] Lens Migration
6 participants
@kush-elastic @elasticmachine @zmoog @drewdaemon @harnish-elastic @milan-elastic