Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IIS] Add dimension field mapping for application_pool datastream to … #6460

Merged
merged 2 commits into from Jun 14, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Jun 5, 2023

  • Enhancement

What does this PR do?

This PR adds dimension fields mapping for the application_pool data stream of IIS to support TSDB enablement.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ritalwar ritalwar mentioned this pull request Jun 5, 2023
16 tasks
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-05T11:37:00.367+0000

  • Duration: 14 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 85.714% (30/35) 👎 -14.286
Lines 93.772% (271/289) 👎 -1.572
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar marked this pull request as ready for review June 6, 2023 05:14
@ritalwar ritalwar requested a review from a team as a code owner June 6, 2023 05:14
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit f82a0ef into elastic:main Jun 14, 2023
3 checks passed
@elasticmachine
Copy link

Package iis - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=iis

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
#6460)

* [IIS] Add dimension field mapping for application_pool datastream to support tsdb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants