New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS API Gateway] Dashboard for metrics datastream #6476
[AWS API Gateway] Dashboard for metrics datastream #6476
Conversation
🌐 Coverage report
|
💚 Build Succeeded
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data types on the dashboard look good: request count, bytes, latency, 4xx, and 5xx errors.
I have a few general questions:
- Labels: should we add a space between the words? For example, "IntegrationErrors" vs. "Integration Error".
- Unit of measure: some visualization may benefit from adding a UOM, like the "ms" on latency values.
- Field name differences: I know that different API Gateway types use distinct field names (
4xx
vs.4XXError
), but should we make this visible or use the same name on the dashboard for consistency since the semantics is the same? - The dashboard is very tall: should we consider splitting somehow?
I am looking forward to hearing from Drew o other Kibana Visualization team members!
@zmoog thanx a lot. I agree that the dashboard looks good and also on:
I agree, let's use the same name on dashboard for consistency Now about the height, in general we encourage small dashboards. I don't know if it makes sense to make 2 or 3 dashboards semantically but if yes I agree. Otherwise we could possibly have more panels per row. |
@zmoog @stratoula This is how the updated dashboard looks: For now I would just bundle all API types in a single dashboard since they all use API Gateway. WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! We can def improve in the future and split in more dashboards but I think is fine for now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as 1.0 🚢
/test |
Package aws - 1.45.1 containing this change is available at https://epr.elastic.co/search?package=aws |
What does this PR do?
Adds a dashboard for API Gateway metrics data stream. WIP.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots