Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate "[Azure Logs] User Activity" dashboard to Lens #6503

Merged
merged 7 commits into from Jun 20, 2023

Conversation

tdancheva
Copy link
Contributor

@tdancheva tdancheva commented Jun 7, 2023

What does this PR do?

Migration of "[Azure Logs] User Activity" dashboard to Lens, style changes and changes according to latest dashboard guidelines

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Before:
BEFORE

After:
AFTER

@tdancheva tdancheva added the enhancement New feature or request label Jun 7, 2023
@tdancheva tdancheva changed the title Dashboard user activity Migrate "[Azure Logs] User Activity" dashboard to Lens Jun 7, 2023
@elasticmachine
Copy link

elasticmachine commented Jun 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-20T14:24:16.461+0000

  • Duration: 16 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22)
Classes 86.364% (19/22)
Methods 83.333% (155/186)
Lines 84.935% (2802/3299)
Conditionals 100.0% (0/0) 💚

@tdancheva tdancheva marked this pull request as ready for review June 7, 2023 14:59
@tdancheva tdancheva requested a review from a team as a code owner June 7, 2023 14:59
@zmoog zmoog requested a review from a team June 8, 2023 09:39
Copy link

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, LGTM!

@kaiyan-sheng kaiyan-sheng self-requested a review June 15, 2023 14:28
@kaiyan-sheng
Copy link
Contributor

@tdancheva What do you think about updating the dashboard screenshots under img dir?

@tdancheva
Copy link
Contributor Author

@tdancheva What do you think about updating the dashboard screenshots under img dir?

Yes, definitely a good idea, will do!

@tdancheva
Copy link
Contributor Author

@tdancheva What do you think about updating the dashboard screenshots under img dir?

Yes, definitely a good idea, will do!

I will put it in a separate PR, just in case, I want to close these as soon as possible.

@tdancheva tdancheva merged commit 192fe3c into elastic:main Jun 20, 2023
4 checks passed
@elasticmachine
Copy link

Package azure - 1.5.21 containing this change is available at https://epr.elastic.co/search?package=azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants