Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws] Add tags_filter and include_linked_accounts in missing metric data streams #6526

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jun 9, 2023

What does this PR do?

Add include_linked_accounts into redshift and apigateway data streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner June 9, 2023 17:30
@elasticmachine
Copy link

elasticmachine commented Jun 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-09T18:48:32.639+0000

  • Duration: 53 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 190
Skipped 4
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👍
Classes 93.75% (15/16) 👍
Methods 85.921% (238/277) 👍
Lines 85.925% (7387/8597) 👍
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng changed the title [aws] Add include_linked_accounts into redshift and apigateway [aws] Add tags_filter and include_linked_accounts in missing metric data streams Jun 9, 2023
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 9, 2023
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng merged commit f689521 into elastic:main Jun 12, 2023
3 checks passed
@kaiyan-sheng kaiyan-sheng deleted the missing_linked_accounts branch June 12, 2023 14:00
@elasticmachine
Copy link

Package aws - 1.43.1 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants