Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][AWS] Migrate AWS Metric Overview dashboard visualizations to lens #6543

Merged

Conversation

rajvi-patel-22
Copy link
Contributor

  • Enhancement

What does this PR do?

Manually migrate AWS Metrics (EC2, SQS, ELB, Lambda) visualizations to the lens in the current Kibana version 8.7.1 itself.

Migration stats

AWS Metrics Dashboard  Before Migration   After Migration  
  Lens Visualization Lens Visualization
Dashboards 0 15 15 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.7.1 itself.

Related issues

Note:

As per the discussion with team, aggregations for the below panels have been modified:

Visualization Field Aggregation [Before] Aggregation [After]
Total # of HTTP 4xx Errors aws.s3_request.errors.4xx Sum Average
Total # of HTTP 5xx Errors aws.s3_request.errors.5xx Sum Average
SQS Empty Receives Top5 aws.sqs.empty_receives Average Last Value
SQS Messages Delayed Top5 aws.sqs.messages.delayed Average Last Value
Cloudwatch ELB Request Count Top5 aws.elb.metrics.RequestCount.sum Sum Sum
Cloudwatch ELB Unhealthy Host Count aws.elb.metrics.UnHealthyHostCount.max Sum Last Value
Cloudwatch Lambda Errors Top5 aws.lambda.metrics.Errors.avg Average Average
Cloudwatch Lambda Invocations Top5 aws.lambda.metrics.Invocations.avg Average Average
Cloudwatch Lambda Throttles Top5 aws.lambda.metrics.Throttles.avg Average Average

Please refer the below Before Migrated screenshot to compare!
image

@rajvi-patel-22 rajvi-patel-22 requested review from a team as code owners June 12, 2023 15:20
@elasticmachine
Copy link

elasticmachine commented Jun 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-14T06:31:25.534+0000

  • Duration: 55 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 190
Skipped 4
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 12, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 85.921% (238/277) 👍 0.206
Lines 85.925% (7387/8597) 👎 -7.846
Conditionals 100.0% (0/0) 💚

@drewdaemon
Copy link
Contributor

Awesome to see this.

A couple of requests:

  • Can we change those metrics to be the new Lens metric (as opposed to the legacy metric)?
  • Can we remove the legacy dashboard controls and replace them with the new stuff? Once you do this, you can
    • convert the pie chart to a treemap visualization (equivalent, but better use of the space)
    • keep the pie chart the same size and just expand the "EC2 CPU Utilization" visualization to make up for the extra space in the first row

@rajvi-patel-22 rajvi-patel-22 self-assigned this Jun 13, 2023
@rajvi-patel-22
Copy link
Contributor Author

A couple of requests:

@drewdaemon, The screenshot in description is before migrated dashboard. I have updated the screenshot in package itself where I have converted the legacy metrics to new metric and also migrated to new control panels.

Please let me know if anything needs to be changed.

Sorry for the confusion!

Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @rajvi-elastic. I should have read more carefully!

Looks good from my end, though you might try changing the color of the horizontal bar graphs to the Lens default so they match the new pie chart (this can be done by deleting the custom color that came over from TSVB).

Approved so as not to hold you up.

Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @rajvi-elastic

@rajvi-patel-22 rajvi-patel-22 merged commit e4b0364 into elastic:main Jun 14, 2023
4 checks passed
@elasticmachine
Copy link

Package aws - 1.44.4 containing this change is available at https://epr.elastic.co/search?package=aws

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
…ens (#6543)

* Migrate AWS Metric Overview dashboard visualizations to lens

* Update changelog

* Update color in bar charts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][AWS Metrics] Lens Migration
5 participants