Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_endpoint: fix handling of include header config #6548

Merged
merged 1 commit into from Jun 13, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 13, 2023

What does this PR do?

Previously the value was being rendered directly without iteration, so we had a comma-separated list instead of a YAML sequence.

Also fix some copy-paste errors.

Computed config now:

- data_stream:
    namespace: default
  id: http_endpoint-http_endpoint-c69b6080-0996-11ee-9698-67a83ee16ff8
  meta:
    package:
      name: http_endpoint
      version: 1.9.1
  name: http_endpoint-1
  package_policy_id: c69b6080-0996-11ee-9698-67a83ee16ff8
  policy:
    revision: 7
  revision: 1
  streams:
  - data_stream:
      dataset: http_endpoint.generic
    id: http_endpoint-http_endpoint.generic-c69b6080-0996-11ee-9698-67a83ee16ff8
    include_headers:
    - user-agent
    - x-real-ip
    listen_address: localhost
    listen_port: 8080
    publisher_pipeline.disable_host: true
    ssl:
      certificate: /etc/pki/client/cert.pem
      enabled: false
      key: /etc/pki/client/cert.key
    tags:
    - forwarded
  type: http_endpoint

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 13, 2023
Previously the value was being rendered directly without iteration, so
we had a comma-separated list instead of a YAML sequence.

Also fix some copy-paste errors.
@elasticmachine
Copy link

elasticmachine commented Jun 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-13T03:09:04.837+0000

  • Duration: 15 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 6.25
Classes 100.0% (0/0) 💚 6.25
Methods 100.0% (3/3) 💚 14.079
Lines 100.0% (0/0) 💚 14.075
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review June 13, 2023 03:27
@efd6 efd6 requested a review from a team as a code owner June 13, 2023 03:27
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit 6922f6d into elastic:main Jun 13, 2023
4 checks passed
@elasticmachine
Copy link

Package http_endpoint - 1.9.1 containing this change is available at https://epr.elastic.co/search?package=http_endpoint

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
Previously the value was being rendered directly without iteration, so
we had a comma-separated list instead of a YAML sequence.

Also fix some copy-paste errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elastic Agent http_endpoint integration does not allow multiple include headers
3 participants