Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Microsoft SQL Server] Migrate Microsoft SQL Server to GA #6574

Merged
merged 4 commits into from Jun 19, 2023

Conversation

muthu-mps
Copy link
Contributor

@muthu-mps muthu-mps commented Jun 14, 2023

  • Enhancement

What does this PR do?

Migrates the integration data streams from BETA to GA

  • performance
  • transaction_log
  • error_log

How to test this PR locally

  • Install the integration
  • Run system and pipeline tests
  • Verify the data loading in Kibana
  • Verify the BETA flags are removed from the datastreams

Related issues

@elasticmachine
Copy link

elasticmachine commented Jun 14, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-14T13:59:48.424+0000

  • Duration: 17 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 93.75% (30/32) 👍 21.023
Lines 100.0% (1251/1251) 💚
Conditionals 100.0% (0/0) 💚

@muthu-mps muthu-mps marked this pull request as ready for review June 14, 2023 13:41
@muthu-mps muthu-mps requested a review from a team as a code owner June 14, 2023 13:41
@muthu-mps muthu-mps changed the title [Microsoft Sqlserver] Migrate microsoft Sqlserver GA [Microsoft Sqlserver] Migrate microsoft Sqlserver to GA Jun 14, 2023
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "2.0.0"
changes:
- description: Make performance, transaction_log & log datastream GA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we keep the "." (fullstop) in the end of the sentences? Please check at the other places as well if its missing.

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shmsr shmsr changed the title [Microsoft Sqlserver] Migrate microsoft Sqlserver to GA [Microsoft SQL Server] Migrate Microsoft SQL Server to GA Jun 15, 2023
@muthu-mps muthu-mps merged commit c5ba136 into elastic:main Jun 19, 2023
4 checks passed
@elasticmachine
Copy link

Package microsoft_sqlserver - 2.0.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Microsoft SqlServer performance & transaction_log & error_log GA
4 participants