New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ti_misp] Fix parsing of threat event publish_timestamp #6575
Merged
chrisberkhout
merged 3 commits into
main
from
ti-misp-threat-event-publish-timestamp-fix
Jun 15, 2023
Merged
[ti_misp] Fix parsing of threat event publish_timestamp #6575
chrisberkhout
merged 3 commits into
main
from
ti-misp-threat-event-publish-timestamp-fix
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
💚 Build Succeeded
|
🌐 Coverage report
|
taylor-swanson
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package ti_misp - 1.15.4 containing this change is available at https://epr.elastic.co/search?package=ti_misp |
sodhikirti07
pushed a commit
that referenced
this pull request
Jun 15, 2023
* Fix values in the pipeline. * Update the pipeline tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes parsing of the threat event
publish_timestamp
field by adding a date step in the ingest pipeline that interprets the incoming value as a second-resolution UNIX timestamp, rather than letting Kibana later misinterpret it as a millisecond-resolution timestamp. This matches what is done for thethreat
data stream to what was already done for thepublish_timestamp
field in thethreat_attributes
data stream.I updated the corresponding pipeline tests.
I manually verified that that the values come out as expected in the Kibana UI.
Checklist
changelog.yml
file.Related issues