Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS] [EMR] Add metrics dashboard #6606

Merged
merged 5 commits into from Jun 19, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Jun 19, 2023

What does this PR do?

Adds metrics dashboard for EMR metrics data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

emr_dashb

@gpop63 gpop63 self-assigned this Jun 19, 2023
@stratoula
Copy link

@gpop63 have you checked how it looks on dark mode? I am mostly concerned about the metrics.

@gpop63
Copy link
Contributor Author

gpop63 commented Jun 19, 2023

This is how it looks in dark mode:
emr_dark_mode

@gpop63
Copy link
Contributor Author

gpop63 commented Jun 19, 2023

I used the default color for metric charts and now it adjusts itself! Thanks @stratoula

Black:
emr_updated

White:
emr_updated_white

Copy link

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now I think. We will work on this and then the transparent will be pure whit but until then this approach is better! LGTM

@elasticmachine
Copy link

elasticmachine commented Jun 19, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-19T14:34:56.119+0000

  • Duration: 53 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 4
Total 198

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -3.36
Classes 93.75% (15/16) 👎 -3.36
Methods 85.714% (240/280) 👎 -6.5
Lines 85.925% (7387/8597) 👎 -6.335
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The values are a little weird, but I know you partially used fake data.

LGTM, but we should add an item in the BETA to GA issue.

@gpop63 gpop63 marked this pull request as ready for review June 19, 2023 15:02
@gpop63 gpop63 requested review from a team as code owners June 19, 2023 15:02
@gpop63 gpop63 merged commit 9699e47 into elastic:main Jun 19, 2023
4 checks passed
@elasticmachine
Copy link

Package aws - 1.45.2 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS] [EMR Metrics] Dashboard
4 participants