Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Ensure event.kind is correctly set for pipeline errors #6612

Merged
merged 4 commits into from Jun 20, 2023

Conversation

MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Jun 19, 2023

What does this PR do?

Modify forwarded data stream for windows integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish requested review from a team as code owners June 19, 2023 22:49
@MakoWish MakoWish requested review from belimawr and faec June 19, 2023 22:49
@elasticmachine
Copy link

elasticmachine commented Jun 19, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-19T23:16:12.936+0000

  • Duration: 16 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@MakoWish MakoWish changed the title 6582 windows [Windows] Ensure event.kind is correctly set for pipeline errors Jun 19, 2023
@MakoWish MakoWish marked this pull request as draft June 19, 2023 23:01
@MakoWish
Copy link
Contributor Author

MakoWish commented Jun 19, 2023

Ugh... why are files from AWS being included in the commit when viewed here? I didn't touch those, and they are not shown in my original commit:

clean_commit

@MakoWish MakoWish marked this pull request as ready for review June 19, 2023 23:09
@efd6
Copy link
Contributor

efd6 commented Jun 19, 2023

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -9.53
Classes 87.5% (7/8) 👎 -9.53
Methods 83.696% (77/92) 👎 -8.456
Lines 92.813% (5153/5552) 👍 0.898
Conditionals 100.0% (0/0) 💚

@efd6 efd6 merged commit 37c62ca into elastic:main Jun 20, 2023
4 checks passed
@MakoWish MakoWish deleted the 6582-windows branch June 20, 2023 21:16
@elasticmachine
Copy link

Package windows - 1.24.0 containing this change is available at https://epr.elastic.co/search?package=windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants