Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jamf_compliance_reporter: ensure event.kind is correctly set for pipeline errors #6615

Merged
merged 1 commit into from Jun 21, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 20, 2023

What does this PR do?

Modify jamf_compliance_reporter to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 20, 2023
@elasticmachine
Copy link

elasticmachine commented Jun 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-20T02:02:15.505+0000

  • Duration: 16 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 11
Skipped 0
Total 11

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (47/47) 💚 2.97
Classes 100.0% (47/47) 💚 2.97
Methods 100.0% (156/156) 💚 7.849
Lines 99.321% (3072/3093) 👍 7.405
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review June 20, 2023 02:19
@efd6 efd6 requested a review from a team as a code owner June 20, 2023 02:19
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit bff969e into elastic:main Jun 21, 2023
4 checks passed
@elasticmachine
Copy link

Package jamf_compliance_reporter - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=jamf_compliance_reporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants