Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hi]*: ensure event.kind is correctly set for pipeline errors #6616

Merged
merged 2 commits into from Jun 21, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 20, 2023

What does this PR do?

Modify hashicorp_vault, hid_bravura_monitor, imperva, infoblox_bloxone_ddi and infoblox_nios to correctly set event.kind for pipeline errors and ensure error.message is an array.

iptables was included but upstream failures block testing so it is omitted.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 20, 2023
hashicorp_vault, hid_bravura_monitor, imperva, infoblox_bloxone_ddi,
infoblox_nios and iptables
@elasticmachine
Copy link

elasticmachine commented Jun 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-20T03:04:10.939+0000

  • Duration: 20 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 126
Skipped 0
Total 126

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 20, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (9/9) 💚
Files 100.0% (13/13) 💚 2.97
Classes 100.0% (13/13) 💚 2.97
Methods 95.62% (131/137) 👍 3.469
Lines 96.664% (3912/4047) 👍 4.748
Conditionals 100.0% (0/0) 💚

reason for revert: the iptables package depends on journald which is failing with

```
{
    "log.level": "error",
    "@timestamp": "2023-06-20T02:59:49.371Z",
    "message": "Input 'journald' failed with: input.go:130: input journald-iptables.log-7d04ae60-0f16-11ee-976c-55635f4b2750 failed (id=journald-iptables.log-7d04ae60-0f16-11ee-976c-55635f4b2750)\n\tinput.go:174: failed to create reader for /run/service_logs/iptables.journal journal (path=/run/service_logs/iptables.journal): reader.go:119: failed to open journal file /run/service_logs/iptables.journal (path=/run/service_logs/iptables.journal): failed to open journals in paths [\"/run/service_logs/iptables.journal\"]: protocol not supported",
    "component": {
        "binary": "filebeat",
        "dataset": "elastic_agent.filebeat",
        "id": "journald-default",
        "type": "journald"
    },
    "log": {
        "source": "journald-default"
    },
    "id": "journald-iptables.log-7d04ae60-0f16-11ee-976c-55635f4b2750",
    "ecs.version": "1.6.0",
    "log.logger": "input.journald",
    "log.origin": {
        "file.line": 131,
        "file.name": "compat/compat.go"
    },
    "service.name": "filebeat"
}
```
@efd6 efd6 marked this pull request as ready for review June 20, 2023 03:24
@efd6 efd6 requested a review from a team as a code owner June 20, 2023 03:25
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 92684ed into elastic:main Jun 21, 2023
4 checks passed
@elasticmachine
Copy link

Package iptables - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=iptables

@elasticmachine
Copy link

Package hashicorp_vault - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=hashicorp_vault

@elasticmachine
Copy link

Package hid_bravura_monitor - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=hid_bravura_monitor

@elasticmachine
Copy link

Package imperva - 0.16.0 containing this change is available at https://epr.elastic.co/search?package=imperva

@elasticmachine
Copy link

Package infoblox_bloxone_ddi - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=infoblox_bloxone_ddi

@elasticmachine
Copy link

Package infoblox_nios - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=infoblox_nios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants