Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modsecurity: fix handling of apache audit.details field #6620

Merged
merged 1 commit into from Jun 22, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 20, 2023

What does this PR do?

Apache provides these as an array of strings, but a flattened must be an object or array of objects. So promote the strings to an object with the string in the "value" field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Jun 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-22T09:58:08.608+0000

  • Duration: 15 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 20, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 100.0% (30/30) 💚 3.846
Lines 91.582% (359/392) 👎 -8.418
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review June 20, 2023 09:55
@efd6 efd6 requested a review from a team as a code owner June 20, 2023 09:55
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Apache provides these as an array of strings, but a flattened must be an
object or array of objects. So promote the strings to an object with the
string in the "value" field.
@efd6 efd6 merged commit d5634a8 into elastic:main Jun 22, 2023
4 checks passed
@elasticmachine
Copy link

Package modsecurity - 1.9.1 containing this change is available at https://epr.elastic.co/search?package=modsecurity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:Modsecurity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[modsecurity] parsing exception - failed to parse field [modsec.audit.details]
3 participants