Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ti_cif3] Ensure event.kind is correctly set for pipeline errors #6631

Merged
merged 7 commits into from
Jun 21, 2023

Conversation

MakoWish
Copy link
Contributor

What does this PR do?

Modify ti_cif3 integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish requested a review from a team as a code owner June 20, 2023 20:09
@elasticmachine
Copy link

elasticmachine commented Jun 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-21T21:55:17.676+0000

  • Duration: 14 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Jun 20, 2023

/test

@MakoWish
Copy link
Contributor Author

Forgot to increment the version in manifest. Done.

efd6
efd6 previously approved these changes Jun 21, 2023
@efd6
Copy link
Contributor

efd6 commented Jun 21, 2023

/test

packages/ti_cif3/manifest.yml Outdated Show resolved Hide resolved
@efd6 efd6 dismissed their stale review June 21, 2023 01:48

Missed spec version error

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@efd6
Copy link
Contributor

efd6 commented Jun 21, 2023

/test

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 85.714% (12/14) 👎 -7.619
Lines 40.755% (108/265) 👎 -56.717
Conditionals 100.0% (0/0) 💚

@efd6 efd6 merged commit 9c069d4 into elastic:main Jun 21, 2023
4 checks passed
@MakoWish MakoWish deleted the 6582-ti_cif3 branch June 21, 2023 22:54
@elasticmachine
Copy link

Package ti_cif3 - 0.8.0 containing this change is available at https://epr.elastic.co/search?package=ti_cif3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants