Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ti_rapid7_threat_command] Ensure event.kind is correctly set for pipeline errors #6635

Merged
merged 6 commits into from Jun 21, 2023

Conversation

MakoWish
Copy link
Contributor

What does this PR do?

Modify ti_rapid7_threat_command integration to correctly set event.kind for pipeline errors and ensure error.message is an array.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  •  

How to test this PR locally

Related issues

Screenshots

@MakoWish MakoWish requested a review from a team as a code owner June 20, 2023 20:22
@elasticmachine
Copy link

elasticmachine commented Jun 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-21T21:55:37.667+0000

  • Duration: 17 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Jun 20, 2023

/test

@elasticmachine
Copy link

elasticmachine commented Jun 20, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 88.372% (38/43) 👎 -4.961
Lines 94.245% (868/921) 👎 -3.227
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've found some that my automation missed, but missed the ones that I found. Can you also add changes for the default.yml files under data_stream/{alert,ioc,vulnerability}/elasticsearch/ingest_pipeline?

@MakoWish
Copy link
Contributor Author

MakoWish commented Jun 21, 2023

Oops! Forgot to change my commit message, but that last Increment version in manifest was for the three default.yml files you pointed out.

@efd6
Copy link
Contributor

efd6 commented Jun 21, 2023

/test

@efd6 efd6 merged commit 3f56c61 into elastic:main Jun 21, 2023
4 checks passed
@MakoWish MakoWish deleted the 6582-ti_rapid7_threat_command branch June 21, 2023 23:02
@elasticmachine
Copy link

Package ti_rapid7_threat_command - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=ti_rapid7_threat_command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants