Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sophos: fix handling of date parsing #6676

Merged
merged 1 commit into from Jun 23, 2023
Merged

sophos: fix handling of date parsing #6676

merged 1 commit into from Jun 23, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 23, 2023

What does this PR do?

Ensure fields that have been defined as date are parseable as date. Also add timezone configuration and progressively determine timezone from logs, config, locale.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jun 23, 2023
@elasticmachine
Copy link

elasticmachine commented Jun 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-23T01:08:04.940+0000

  • Duration: 19 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (13/13) 💚
Classes 100.0% (13/13) 💚
Methods 98.901% (90/91) 👍 0.037
Lines 93.776% (1808/1928) 👍 3.07
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review June 23, 2023 01:57
@efd6 efd6 requested a review from a team as a code owner June 23, 2023 01:57
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit 9be4dab into elastic:main Jun 23, 2023
4 checks passed
@elasticmachine
Copy link

Package sophos - 2.11.0 containing this change is available at https://epr.elastic.co/search?package=sophos

1 similar comment
@elasticmachine
Copy link

Package sophos - 2.11.0 containing this change is available at https://epr.elastic.co/search?package=sophos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Integration:Sophos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sophos][xg] Failed to parse field [sophos.xg.eventtime] exceptions
3 participants