Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] [AWS Orgs] Add config option #6682

Conversation

orestisfl
Copy link
Contributor

Adds the aws.account_type enum option which can take the single_account and organization_account values.

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@orestisfl orestisfl requested a review from kfirpeled June 23, 2023 14:00
@orestisfl orestisfl self-assigned this Jun 23, 2023
@orestisfl orestisfl requested a review from a team as a code owner June 23, 2023 14:00
@orestisfl orestisfl force-pushed the cloudbeat-1037/aws-orgs-update-cloudbeatyml-config-to-enable-multi-account-fetching branch from 6847524 to f78fed3 Compare June 23, 2023 14:00
@elasticmachine
Copy link

elasticmachine commented Jun 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-26T07:58:39.546+0000

  • Duration: 14 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
@orestisfl please make sure to inform the team we branch out 1.5 and remind them that for backporting to 1.4 they'll need to create a new branch

Adds the `aws.account_type` enum option which can take the
`single_account` and `organization_account` values.
@orestisfl orestisfl force-pushed the cloudbeat-1037/aws-orgs-update-cloudbeatyml-config-to-enable-multi-account-fetching branch from f78fed3 to 712bc08 Compare June 26, 2023 07:58
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.769
Classes 100.0% (0/0) 💚 2.769
Methods 25.0% (2/8) 👎 -68.14
Lines 100.0% (0/0) 💚 8.415
Conditionals 100.0% (0/0) 💚

@orestisfl orestisfl merged commit 26a538f into elastic:main Jun 26, 2023
4 checks passed
@orestisfl orestisfl deleted the cloudbeat-1037/aws-orgs-update-cloudbeatyml-config-to-enable-multi-account-fetching branch June 26, 2023 08:15
@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview20 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@kfirpeled kfirpeled added the Team:Cloud Security Label for the Cloud Security team label Jun 26, 2023
@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview21 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview22 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview23 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview24 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview25 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview26 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0-preview27 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud Security Label for the Cloud Security team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS Orgs] Update cloudbeat.yml config to enable multi-account fetching
3 participants